Khalid Alaoui, iOS DEVELOPER

The tab that pointed at nothing

// Index against the list that actually built viewControllers,
// not a freshly recomputed one that can drift.
let bottomItems = currentTabItems

guard let tabs = self.viewControllers, tabs.indices.contains(index) else {
    self.updateViewController()
    return
}

The coordinator that never died

childCoordinators.append(coordinator)
coordinator.didFinishAuth_ = { [weak self] user in
    guard let self else { return }
    self.tabBar.update(user)
}
coordinator.didCancelAuth = { [weak coordinator] in
    coordinator?.navigationController.popToRootViewController(animated: true)
}

The same pattern turned up in other coordinators, and I fixed those in the same pass.

1,000 DateFormatters per checkout

enum CachedDateFormatter {
    private static let lock = NSLock()
    private static var cache: [String: DateFormatter] = [:]

    static func formatter(_ format: String, timeZone: TimeZone? = nil) -> DateFormatter {
        let key = "\(format)|\(timeZone?.identifier ?? "")"
        lock.lock(); defer { lock.unlock() }
        if let existing = cache[key] { return existing }
        let f = DateFormatter(); f.dateFormat = format
        if let timeZone { f.timeZone = timeZone }
        cache[key] = f
        return f
    }
}

The same performance pass also removed main-thread CLLocationManager calls flagged by Xcode's Thread Performance Checker, bounded the image cache, and paused timers in the background.

Tracking, only with consent

private func requestFacebookTrackingAuthorizationIfNeeded() {
    guard !hasRequestedTrackingAuthorization else { return }
    hasRequestedTrackingAuthorization = true

    let facebookCouldTrack = AnalyticsConfig.facebookEnabled
        && !MerchantManager.shared.config.facebookAppId.isEmpty
    guard facebookCouldTrack else { return }

    requestTrackingAuthorization { authorized in
        Settings.isAdvertiserIDCollectionEnabled = authorized
        if authorized { AnalyticsTracker.shared.enableFacebookTracking() }
    }
}

It builds on my rewrite of analytics into one opt-in fan-out tracker: Firebase, Facebook and our own server are separate backends, each enabled per merchant.

18 tests in an empty target

func testMidnightEndTreatedAsEndOfDay() {
    // 18:00 -> 00:00 means "open until midnight", not "closed at 00:00".
    XCTAssertEqual(badge(hours("wednesday", 1800, 0), at: wednesday(hour: 20))?.state, .open)
}

func testClosingSoonWithinLastHour() {
    let result = badge(hours("wednesday", 900, 2100), at: wednesday(hour: 20, minute: 30))
    XCTAssertEqual(result?.state, .closingSoon)
}